Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow deps discover command #1761

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Add flow deps discover command #1761

merged 3 commits into from
Sep 23, 2024

Conversation

jribbink
Copy link
Contributor

@jribbink jribbink commented Sep 20, 2024

Closes #1754

Description

Adds flow deps discover command to allow users to interactively install Core Contracts.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 2.27273% with 43 lines in your changes missing coverage. Please review.

Project coverage is 29.48%. Comparing base (a78ff06) to head (0b5e3e1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/dependencymanager/discover.go 0.00% 42 Missing ⚠️
internal/super/setup.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1761      +/-   ##
==========================================
- Coverage   29.54%   29.48%   -0.07%     
==========================================
  Files          88       89       +1     
  Lines        5154     5169      +15     
==========================================
+ Hits         1523     1524       +1     
- Misses       3444     3458      +14     
  Partials      187      187              
Flag Coverage Δ
unittests 29.48% <2.27%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chasefleming
Copy link
Member

@jribbink Dont forget to update the docs for these new commands please.

@jribbink jribbink merged commit f99a061 into master Sep 23, 2024
12 checks passed
@jribbink jribbink deleted the jribbink/discover-deps branch September 23, 2024 21:44
@jribbink jribbink added Improvement Technical work without new features, refactoring, improving tests Feature A new user feature or a new package API and removed Improvement Technical work without new features, refactoring, improving tests labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature A new user feature or a new package API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to list core contracts in Dependency Manager
3 participants