Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json encoding for transaction result #1768

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

ryokik
Copy link
Contributor

@ryokik ryokik commented Sep 24, 2024

Closes #1715

Description

Fixed the issue where an empty string was returned when using flow transaction get with the -o json option.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@ryokik ryokik changed the title Fix transaction json Fix transaction result json value Sep 24, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.68%. Comparing base (f99a061) to head (ecc8619).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1768   +/-   ##
=======================================
  Coverage   29.68%   29.68%           
=======================================
  Files          89       89           
  Lines        5191     5191           
=======================================
  Hits         1541     1541           
  Misses       3463     3463           
  Partials      187      187           
Flag Coverage Δ
unittests 29.68% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryokik ryokik changed the title Fix transaction result json value Fix json encoding for transaction result Sep 24, 2024
@jribbink
Copy link
Contributor

Thanks for the contribution! Will review today 🫡

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Must have broken at some point as event encoding changed to CCF :)

@jribbink jribbink merged commit fd6649d into onflow:master Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flow-c1 json output not produced for transaction result
3 participants