-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace engine.Unit with ComponentManager in Pusher Engine #6747
base: feature/pusher-engine-refactor
Are you sure you want to change the base?
replace engine.Unit with ComponentManager in Pusher Engine #6747
Commits on Nov 21, 2024
-
replace engine.Unit with ComponentManager in Pusher Engine
Using #4219 as an example. Instead of starting new goroutines or directly processing messages in a blocking way, messages are added to a queue that a worker pulls from. The Pusher engine still currently implements network.Engine rather than network.MessageProcessor.
Configuration menu - View commit details
-
Copy full SHA for 3552f06 - Browse repository at this point
Copy the full SHA 3552f06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d3f462 - Browse repository at this point
Copy the full SHA 6d3f462View commit details -
Pusher engine test: update negative test
Because the event processing now happens in a worker, any errors raised within it are no longer visible to the caller of Process(). Because the test checked for error status, moved the tests to the same package and call the internal processing function directly.
Configuration menu - View commit details
-
Copy full SHA for 0aadc13 - Browse repository at this point
Copy the full SHA 0aadc13View commit details -
When using Unit, calling Ready would also start the engine. With ComponentManager, we additionally need to invoke Start.
Configuration menu - View commit details
-
Copy full SHA for dec0d58 - Browse repository at this point
Copy the full SHA dec0d58View commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b5418dd - Browse repository at this point
Copy the full SHA b5418ddView commit details
Commits on Nov 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b7166f3 - Browse repository at this point
Copy the full SHA b7166f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e25cba7 - Browse repository at this point
Copy the full SHA e25cba7View commit details -
Refactor pusher engine: rename and propagate error
Rename `inboundMessageWorker` and `processInboundMessages` to `outbound` and also propagate errors to the top level of the worker where they can be thrown.
Configuration menu - View commit details
-
Copy full SHA for f2f53a8 - Browse repository at this point
Copy the full SHA f2f53a8View commit details -
- Partially implement suggestion #6747 (comment) - Make `SubmitCollectionGuarantee` non-exported and rename to `publishCollectionGuarantee` - Add new `SubmitCollectionGuarantee` exported function that just adds to the queue - Remove `messageHandler` field, instead directly add to queue from review: #6747 (comment) - `OriginID`s no longer included in messages in the queue, and therefore not checked by the worker - if necessary they should be checked when Submitting
Configuration menu - View commit details
-
Copy full SHA for f66ba69 - Browse repository at this point
Copy the full SHA f66ba69View commit details -
Revert "Pusher engine test: update negative test"
This reverts commit 0aadc13. Instead of testing the internals, test the exported interface.
Configuration menu - View commit details
-
Copy full SHA for 1c80949 - Browse repository at this point
Copy the full SHA 1c80949View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbed8e7 - Browse repository at this point
Copy the full SHA fbed8e7View commit details -
Merge branch 'feature/pusher-engine-refactor' into tim/7018-pusher-en…
…gine-use-componentmanager
Configuration menu - View commit details
-
Copy full SHA for 051e6d4 - Browse repository at this point
Copy the full SHA 051e6d4View commit details
Commits on Nov 29, 2024
-
Refactor pusher engine: queue length metrics
Rename queue and add length metrics for it, updating creation sites.
Configuration menu - View commit details
-
Copy full SHA for ddb0cb7 - Browse repository at this point
Copy the full SHA ddb0cb7View commit details -
Update pusher engine doc comment
Co-authored-by: Alexander Hentschel <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 17a9a2b - Browse repository at this point
Copy the full SHA 17a9a2bView commit details
Commits on Nov 30, 2024
-
Apply suggestions from code review
Doc comment changes, metrics naming, and queue length. For reasoning behind chosen queue length, see #6747 (comment) Co-authored-by: Jordan Schalm <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aad332c - Browse repository at this point
Copy the full SHA aad332cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ad04f27 - Browse repository at this point
Copy the full SHA ad04f27View commit details