-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some emoji is missing #10
Comments
Thanks @aleksandrshoshiashvili I pushed a first fix for this. When I tried XCTAssertEqual(Smile.extractEmojis(string: "Hello ⏰⌛️💳🆙."), "⏰⌛️💳🆙") I got
Only ⌛️ seems to bug. Which function failed with the other emojis? Also, thanks a lot for the unicode ranges! Where did you get those from? |
@Francescu I tested the validator for TextField by entering all the emoji one by one, so I found out that Smile.isEmoji returned wrong result for some of them. I printed their unicodes and update switch according to it :) Unfortunately, I forgot what exactly the emoji are wrong, because I did it couple of weeks ago, just decided to share my finding with you. |
@aleksandrshoshiashvili wow, nice! Thanks a lot for the answers. I'll dig more and use the |
For example: ⏰⌛️💳🆙...
I suggest to update switch:
The text was updated successfully, but these errors were encountered: