Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First fix for issue #10 #11

Merged
merged 2 commits into from
Aug 23, 2018
Merged

First fix for issue #10 #11

merged 2 commits into from
Aug 23, 2018

Conversation

Francescu
Copy link
Collaborator

Regarding issue #10

When I tried

XCTAssertEqual(Smile.extractEmojis(string: "Hello ⏰⌛️💳🆙."), "⏰⌛️💳🆙")

I got

XCTAssertEqual failed: ("⏰️💳🆙") is not equal to ("⏰⌛️💳🆙")

So only ⌛️ seems to bug for now.

I fixed adding 0x231B, which is ⌛️, in the list.

I also added the range 0x23F0...0x23FA

which at least includes

⏳ Hourglass Not Done | U+23F3
⏰ Alarm Clock | U+23F0
⏱️ Stopwatch | U+23F1, U+FE0F
⏲️ Timer Clock | U+23F2, U+FE0F
⏸️ Pause Button | U+23F8, U+FE0F
⏹️ Stop Button | U+23F9, U+FE0F
⏺️ Record Button | U+23FA, U+FE0F

@Francescu
Add tests for Issue #10
1c631dd
@Francescu
Fix for issue #10
73b7d85 
This fix might be a partial fix
@onmyway133
Copy link
Owner

@Francescu Looks good to me. I think for complete list, we need to dump that list from iOS somehow

@onmyway133 onmyway133 merged commit 0b626b7 into master Aug 23, 2018
@onmyway133 onmyway133 deleted the francescu/issue_10 branch August 23, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Francescu @onmyway133