Aaron main dev #17
Merged
Aaron main dev #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I figured out the monumentally ********* thing that was causing the pass backend to act strange. In onomy there is a Name var that is used throughout to set many things to "onomy". In multiverse I used AppName instead because it was what the ICS people used in their examples. I assumed that this was a constant used by just app.toml to propogate the name around from a single place. It turns out that it actually overrides variables set in version.go in cosmos-sdk. Name is set to an empty string by default. There is also a feature where the build script in the makefile can set AppName via environment variable which is how it set both variables. In the multiverse repo only AppName was set. This would leave it to default to an empty string, and there is another out of the way function that converts this to the default "cosmos" without any warnings. For whatever insane reason and you can ctrl+F version.Name in the SDK, the global Name variable is used by one line that sets the keyring service name, and is used nowhere else, not even in any tests. So nothing except a single issue with one keyring backend manifested any issues. After adding two lines to the makefile it starts working as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.