Skip to content

add gov for Active Collateral module vaults #65

add gov for Active Collateral module vaults

add gov for Active Collateral module vaults #65

Triggered via pull request October 1, 2024 04:10
@DongLieuDongLieu
synchronize #27
dong/gov-dev
Status Failure
Total duration 49s
Artifacts

golangci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 2 warnings
lint: x/auction/client/cli/tx.go#L16
const `listSeparator` is unused (unused)
lint: x/vaults/keeper/vault.go#L436
Error return value of `k.SetVault` is not checked (errcheck)
lint: x/vaults/keeper/vault.go#L496
Error return value of `k.SetVault` is not checked (errcheck)
lint: x/vaults/keeper/vault.go#L505
Error return value of `k.SetVault` is not checked (errcheck)
lint: x/auction/keeper/abci.go#L24
Error return value of `k.lastestAuctionPeriod.Set` is not checked (errcheck)
lint: x/auction/keeper/abci.go#L84
Error return value of `k.refundBidders` is not checked (errcheck)
lint: x/vaults/keeper/vaults_test.go#L489
Error return value of `s.App.BankKeeper.MintCoins` is not checked (errcheck)
lint: x/vaults/keeper/vaults_test.go#L490
Error return value of `s.App.BankKeeper.SendCoinsFromModuleToAccount` is not checked (errcheck)
lint: x/vaults/keeper/vaults_test.go#L494
Error return value of `s.App.BankKeeper.MintCoins` is not checked (errcheck)
lint: x/auction/keeper/keeper.go#L82
SA1019: sdk.LengthPrefixedAddressKey is deprecated: LengthPrefixedAddressKey implements an SDK backwards compatible indexing key encoder for addresses. The status quo in the SDK is that address keys are length prefixed even when they're the last part of a composite key. This should never be used unless to retain state compatibility. For example, a composite key composed of `[string, address]` in theory would need you only to define a way to understand when the string part finishes, we usually do this by appending a null byte to the string, then when you know when the string part finishes, it's logical that the part which remains is the address key. In the SDK instead we prepend to the address key its length too. (staticcheck)
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint
Restore cache failed: Dependencies file is not found in /home/runner/work/reserve/reserve. Supported file pattern: go.sum