Merge pull request #85 from onomyprotocol/dong/validate-msg-vaults

vaults: Add validate StabilityFee
onomyprotocol · Nov 7, 2024 · 10140e7 · 10140e7
2 parents 765d1a9 + 16835b5
commit 10140e7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/x/vaults/types/msgs.go b/x/vaults/types/msgs.go
@@ -139,6 +139,10 @@ func (msg *MsgActiveCollateral) ValidateBasic() error {
 		return fmt.Errorf("minCollateralRatio cannot be less than 0")
 	}
 
+	if msg.StabilityFee.LTE(math.LegacyZeroDec()) {
+		return fmt.Errorf("StabilityFee cannot be less than 0")
+	}
+
 	if msg.LiquidationPenalty.LT(math.LegacyZeroDec()) {
 		return fmt.Errorf("minCollateralRatio cannot be less than 0")
 	}
@@ -174,6 +178,10 @@ func (msg *MsgUpdatesCollateral) ValidateBasic() error {
 		return fmt.Errorf("minCollateralRatio cannot be less than 0")
 	}
 
+	if msg.StabilityFee.LTE(math.LegacyZeroDec()) {
+		return fmt.Errorf("StabilityFee cannot be less than 0")
+	}
+
 	if msg.LiquidationPenalty.LT(math.LegacyZeroDec()) {
 		return fmt.Errorf("minCollateralRatio cannot be less than 0")
 	}

diff --git a/x/vaults/types/params.go b/x/vaults/types/params.go
@@ -13,7 +13,6 @@ var (
 	DefaultLiquidationPenalty    = math.LegacyMustNewDecFromStr("0.05")
 	DefaultMinInitialDebt        = math.NewInt(50_000_000)
 	DefaultRecalculateDebtPeriod = time.Hour
-	DefaultLiquidatePeriod       = time.Hour
 	DefaultMintDenom             = []string{"nomUSD"}
 
 	KeyMintingFee            = []byte("MintingFee")