add TestGetPrice #22
Closed
add TestGetPrice #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanhNhann
reviewed
Sep 25, 2024
There was a problem hiding this comment.
The idea for the unit test is good but we should make it clearer with table driven test struct like this example, I suggest to setup all the fail case first then the successful case after
| } | ||
| err := app.OracleKeeper.SetBandPriceState(ctx, "ATOM", bandPriceStateATOM) | ||
| require.NoError(t, err) | ||
|
|
There was a problem hiding this comment.
We should add the check app.OracleKeeper.GetPrice
| } | ||
| err = app.OracleKeeper.SetBandPriceState(ctx, "USD", bandPriceStateUSD) | ||
| require.NoError(t, err) | ||
|
|
| @@ -219,7 +219,7 @@ func (k *Keeper) GetAllBandPriceStates(ctx sdk.Context) []*types.BandPriceState | |||
| func (k *Keeper) GetPrice(ctx sdk.Context, base, quote string) *math.LegacyDec { | |||
| // query ref by using GetBandPriceState | |||
| basePriceState := k.GetBandPriceState(ctx, base) | |||
| if basePriceState == nil { | |||
| if basePriceState == nil || basePriceState.Rate.IsZero() { | |||
| price = app.OracleKeeper.GetPrice(ctx, "ATOM", "USD") | ||
| require.Nil(t, price) | ||
|
|
||
| // Case 5: Quote price is invalid (rate is zero), expect nil |
There was a problem hiding this comment.
This case seems wrong because when quote=USD the code will return here
reserve/x/oracle/keeper/band_oracle.go
Line 226 in e4055d4
ATOM at line 175 above with invalid rate so maybe it return nil at here (we tested in case 4)reserve/x/oracle/keeper/band_oracle.go
Line 222 in 1230d5e
I recommend we should rewrite this test with table-driven test to easy keep track all the test case and follow the logic of each test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.