Skip to content

Commit

Permalink
Fix: showing loader when there is no properties & Register form bug n…
Browse files Browse the repository at this point in the history
…ot conserving values after errors (#405)

* Fix locales EN and FR with a bunch of changes  (#391)

* Fixing fr and en locales (step 1)

* Fixing fr and en locales (step 2)

* Fixing fr and en locales (step 3)

* fix bug of the loader when there is no properties

* fix bug of conserve values (firstname and lastname)

* add the id of container to hide the loader

---------

Co-authored-by: Clement Jonquet <[email protected]>
Co-authored-by: Syphax bouazzouni <[email protected]>
  • Loading branch information
3 people authored Dec 8, 2023
1 parent a443071 commit 388cbab
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions app/assets/javascripts/bp_property_tree.js
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,7 @@
} else {
ROOT.html("No properties exist for this ontology");
ROOT.css("font-size", "14px").css("margin", "5px");
jQuery("#prop_contents .spinner-border").hide()
}

if (typeof OPTIONS.onInit === 'function') { OPTIONS.onInit(); }
Expand Down
4 changes: 2 additions & 2 deletions app/views/users/_form.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
%p.register-input-title
= t('register.first_name')
%font{:color => "red"} *
= text_field :user, :firstName, value: @user.firstname, class: "register-input-short"
= text_field :user, :firstName, value: @user.firstName, class: "register-input-short"
%div
%p.register-input-title
= t('register.last_name')
%font{:color => "red"} *
= text_field :user, :lastName, value: @user.lastname, class: "register-input-short"
= text_field :user, :lastName, value: @user.lastName, class: "register-input-short"
%p.register-input-title
= t('register.username')
%font{:color => "red"} *
Expand Down
1 change: 0 additions & 1 deletion config/bioportal_config_env.rb.sample
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,6 @@ $FOOTER_LINKS = {

$NOT_DOWNLOADABLE = {}


$UI_THEME = ENV['UI_THEME'] || 'ontoportal'
$HOSTNAME = ENV['API_URL']
if $HOSTNAME
Expand Down
1 change: 1 addition & 0 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,7 @@ en:
about_us: About Us
projects: D2KAB
team: Team

login:
enter_email: Enter your username
enter_password: Enter your password
Expand Down

0 comments on commit 388cbab

Please sign in to comment.