Feature: Add rubocop github ci to prevent no localize variables

.github/workflows/rubocop.yml

@@ -0,0 +1,36 @@
+name: Linters
+
+on: [push, pull_request]
+
+jobs:
+  rubocop:
+    name: RuboCop
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0.0
+
+      - name: Install dependencies
+        run: gem install rubocop rubocop-rails rubocop-i18n
+
+
+      - name: Run RuboCop
+        run: rubocop  --parallel --format github
+
+  haml-lint:
+    name: HamlLint
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install HamlLint
+        run: gem install  haml-lint
+
+      - name: Run HamlLint
+        run: haml-lint -r github

.github/workflows/tests.yml

@@ -1,61 +1,23 @@
-# This workflow uses actions that are not certified by GitHub.
-# They are provided by a third-party and are governed by
-# separate terms of service, privacy policy, and support
-# documentation.
-# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
-# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
-name: "Run local API tests CI"
+name: RuboCop
+
+on: [push, pull_request]
 
-on:
-  push:
-  pull_request:
-    types: [ opened, reopened ]
-env:
-  API_URL: http://localhost:9393
-  REMOTE_API_KEY: 8b5b7825-538d-40e0-9e9e-5ab9274a9aeb
-  REMOTE_API_URL: https://data.bioontology.org
-  BIOMIXER_URL: ${{ secrets.BIOMIXER_URL }}
-  FAIRNESS_URL: ${{ secrets.FAIRNESS_URL }}
-  ANNOTATOR_URL: ${{ secrets.ANNOTATOR_URL }}
-  DB_HOST: 127.0.0.1
 jobs:
-  test:
+  rubocop:
     runs-on: ubuntu-latest
-    services:
-      mysql:
-        image: mysql:8.0
-        ports:
-          - "3306:3306"
-        env:
-          MYSQL_ROOT_PASSWORD: root
-      memcached:
-        image: memcached:1.6
-        ports:
-          - 11211:11211
+
     steps:
-      - name: Checkout code
-        uses: actions/checkout@v3
-      # Add or replace dependency steps here
-      - name: Install Ruby and gems
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7.8
-          bundler-cache: true
+          ruby-version: 2.7 # You can change this to your preferred Ruby version
 
-      - name: Run OntoPortal API
-        run: bin/run_api -k ${{ env.REMOTE_API_KEY }} -r agroportal -t development -s STY -u ${{ env.REMOTE_API_URL }}
+      - name: Install RuboCop
+        run:
+          gem install rubocop rubocop-rails
 
-      # Add or replace database setup steps here
-      - name: set up config file
-        run: cp config/database.yml.sample config/database.yml
-      - name: Set up database schema
-        run: RAILS_ENV=test bin/rails db:setup
-      - name: Set up yarn
-        run: yarn install
-      # Add or replace test runners here
-      - name: Run tests
-        run:  COVERAGE=true RAILS_ENV=test bin/rails test -v
-      - name: Upload coverage reports to Codecov
-        uses: codecov/codecov-action@v3
-        env:
-          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+      - name: Run RuboCop
+        run: rubocop --parallel --format github

.haml-lint.yml

@@ -0,0 +1,137 @@
+require:
+  - './lib/lint/no_localized_string_haml.rb' 
+
+linters:
+  CustomLinter:
+    enabled: true
+    include: '**/*.haml'
+
+# Default application configuration that all configurations inherit from.
+#
+# This is an opinionated list of which hooks are valuable to run and what their
+# out of the box settings should be.
+
+# Whether to ignore frontmatter at the beginning of HAML documents for
+# frameworks such as Jekyll/Middleman
+skip_frontmatter: false
+
+linters:
+
+  MyFirstLinter: 
+    enabled: true
+
+  NoPlainTextLinter:
+    enabled: true
+
+  AlignmentTabs:
+    enabled: true
+
+  AltText:
+    enabled: false
+
+  ClassAttributeWithStaticValue:
+    enabled: true
+
+  ClassesBeforeIds:
+    enabled: true
+
+  ConsecutiveComments:
+    enabled: true
+    max_consecutive: 1
+
+  ConsecutiveSilentScripts:
+    enabled: true
+    max_consecutive: 2
+
+  EmptyObjectReference:
+    enabled: true
+
+  EmptyScript:
+    enabled: true
+
+  FinalNewline:
+    enabled: true
+    present: true
+
+  HtmlAttributes:
+    enabled: true
+
+  IdNames:
+    enabled: true
+    style: lisp_case
+
+  ImplicitDiv:
+    enabled: true
+
+  Indentation:
+    enabled: true
+    character: space # or tab
+    width: 2 # ignored if character == tab
+
+  InlineStyles:
+    enabled: true
+
+  InstanceVariables:
+    enabled: true
+    file_types: partials
+    matchers:
+      all: .*
+      partials: \A_.*\.haml\z
+
+  LeadingCommentSpace:
+    enabled: true
+
+  LineLength:
+    enabled: true
+    max: 80
+
+  MultilinePipe:
+    enabled: true
+
+  MultilineScript:
+    enabled: true
+
+  NoPlaceholders:
+    enabled: false
+
+  ObjectReferenceAttributes:
+    enabled: true
+
+  RepeatedId:
+    enabled: true
+    severity: error
+
+  RuboCop:
+    enabled: true
+    # Users can ignore cops using this configuration instead of editing their rubocop configuration.
+    # Mostly there for backward compatibility.
+    ignored_cops: []
+
+  RubyComments:
+    enabled: true
+
+  SpaceBeforeScript:
+    enabled: true
+
+  SpaceInsideHashAttributes:
+    enabled: true
+    style: space
+
+  TagName:
+    enabled: true
+
+  TrailingEmptyLines:
+    enabled: true
+
+  TrailingWhitespace:
+    enabled: true
+
+  UnnecessaryInterpolation:
+    enabled: true
+
+  UnnecessaryStringOutput:
+    enabled: true
+
+  ViewLength:
+    enabled: true
+    max: 100

.rubocop.yml

@@ -0,0 +1,82 @@
+AllCops:
+  NewCops: disable
+  Exclude:
+    - db/migrate/**/*
+    - db/schema.rb
+    - config/**/*
+    - script/**/*
+    - bin/**/*
+    - test/**/*
+    - app/admin/**/*
+    - app/channels/**/*
+    - app/jobs/**/*
+    - node_modules/**/*
+    - Gemfile
+    - Rakefile
+    - config.ru
+
+require:
+  - rubocop-rails
+  - ./lib/lint/non_localized_string.rb
+  - rubocop-i18n
+Lint/NonLocalizedString:
+  Enabled: true
+
+Style/Encoding:
+  Enabled: false
+
+Style/Documentation:
+  Description: 'Document classes and non-namespace modules.'
+  Enabled: false
+
+Style/InlineComment:
+  Description: 'Avoid inline comments.'
+  Enabled: false
+
+Layout/LineLength:
+  Description: 'Limit lines to 100 characters. (Default is 80)'
+  Max: 100
+
+Style/FrozenStringLiteralComment:
+  Description: To help transition from Ruby 2.3.0 to Ruby 3.0.
+  Enabled: false
+
+Style/WordArray:
+  Description: 'Use %w or %W for arrays of words.'
+  Enabled: false
+
+# Defaults all strings to double quotes. Less performant, but
+# nicer for consistency, and for adding interpolation later.
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+# Prettier hashes.
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+
+# No auto-correct for unused block arguments,
+# but will still warn.
+Lint/UnusedBlockArgument:
+  AutoCorrect: false
+
+# No auto-correct for unused method arguments,
+# but will still warn.
+Lint/UnusedMethodArgument:
+  AutoCorrect: false
+
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+Layout/HeredocIndentation:
+  Enabled: false
+
+Style/MissingRespondToMissing:
+  Enabled: false
+
+Lint/MissingSuper:
+  Enabled: true
+
+
+Rails/I18nLocaleTexts:
+  Enabled: true

Gemfile

@@ -13,10 +13,9 @@ gem 'terser' #ugilifer replacent
 # gem 'duktape'
 
 gem 'bootstrap', '~> 4.2.0'
-gem 'chart-js-rails'
 gem 'jquery-rails'
 gem 'jquery-ui-rails'
-gem 'select2-rails'
+
 
 
 # The original asset pipeline for Rails [https://github.com/rails/sprockets-rails]
@@ -109,6 +108,7 @@ group :development do
   # static code analysis
   gem 'brakeman', require: false
   gem 'rubocop', require: false
+  gem 'rubocop-rails'
   # gem 'i18n-debug'
   # See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
   gem 'debug', platforms: %i[ mri mingw x64_mingw ]
@@ -118,6 +118,9 @@ group :development do
   gem 'i18n-tasks'
   gem 'deepl-rb'
   gem 'letter_opener_web', '~> 2.0'
+  gem 'haml-rails'
+  gem "rubocop-i18n", "~> 3.0"
+  gem 'haml_lint', require: false
 end
 
 group :test, :development do
@@ -139,4 +142,4 @@ gem "net-http", "~> 0.3.2"
 
 
 
-gem "bugsnag", "~> 6.26"
+gem "bugsnag", "~> 6.26"