Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Watch button count and state #838

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

Bilelkihal
Copy link
Collaborator

@Bilelkihal Bilelkihal commented Nov 7, 2024

Related issue: #819

Source of issue
To get the subscriptions of a user we used to the the call with the param ?include=subscription which used to display the users with their subscription list that includes ontologies acronyms, but after idk what we did in the back side the same call gives us a result like this one

image

The solution is to do include=all and this is the result of it
image

Demo

Enregistrement.de.l.ecran.2024-11-07.a.19.08.03.mov

@Bilelkihal Bilelkihal self-assigned this Nov 7, 2024
Copy link
Collaborator Author

@Bilelkihal Bilelkihal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on fixing that, can you open an issue in the API repo, so that we fix also in the back someday,

@syphax-bouazzouni
Copy link
Collaborator

But seems that tests are not passing ? @Bilelkihal

@Bilelkihal
Copy link
Collaborator Author

Good job on fixing that, can you open an issue in the API repo, so that we fix also in the back someday,

Done: ontoportal-lirmm/ontologies_api#108

@Bilelkihal
Copy link
Collaborator Author

But seems that tests are not passing ? @Bilelkihal

Errors not related to this PR, I think that they are already in the dev branch, I need to fix them in a separate PR and merge it

@syphax-bouazzouni syphax-bouazzouni merged commit 10237aa into development Nov 8, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants