Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all LegacyKeyValueFormat docker warnings #2717

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

rkuo-danswer
Copy link
Contributor

Description

Fixes DAN-784.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 10:32pm

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 7, 2024 22:54
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses LegacyKeyValueFormat Docker warnings by updating environment variable assignment syntax in multiple Dockerfiles.

  • Updated PYTHONPATH syntax from 'ENV PYTHONPATH /app' to 'ENV PYTHONPATH=/app' in backend/Dockerfile
  • Modified PYTHONPATH format in backend/Dockerfile.model_server to use equals sign
  • Fixed PYTHONPATH declaration in backend/tests/integration/Dockerfile for correct test execution
  • Added '=' signs between environment variable names and values in web/Dockerfile

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@rkuo-danswer rkuo-danswer merged commit 7b3c433 into main Oct 8, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the bugfix/docker-legacy-key-value-format branch October 9, 2024 00:31
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer added a commit that referenced this pull request Oct 9, 2024
…ue-format

Fix all LegacyKeyValueFormat docker warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant