-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all LegacyKeyValueFormat docker warnings #2717
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses LegacyKeyValueFormat Docker warnings by updating environment variable assignment syntax in multiple Dockerfiles.
- Updated PYTHONPATH syntax from 'ENV PYTHONPATH /app' to 'ENV PYTHONPATH=/app' in backend/Dockerfile
- Modified PYTHONPATH format in backend/Dockerfile.model_server to use equals sign
- Fixed PYTHONPATH declaration in backend/tests/integration/Dockerfile for correct test execution
- Added '=' signs between environment variable names and values in web/Dockerfile
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
rkuo-danswer
added a commit
that referenced
this pull request
Oct 9, 2024
…ue-format Fix all LegacyKeyValueFormat docker warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DAN-784.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: