Move user fetching to SS + parallelize some server-side calls #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
commented
Oct 26, 2024
| @@ -55,11 +53,14 @@ export default async function RootLayout({ | |||
| }: { | |||
| children: React.ReactNode; | |||
| }) { | |||
| const combinedSettings = await fetchSettingsSS(); | |||
There was a problem hiding this comment.
PSA: do not have sequential requests in server-side components!
pablonyx
approved these changes
Oct 26, 2024
| } | ||
|
|
||
| return ( | ||
| <div className="mx-3 mt-6 gap-y-1 flex-col flex gap-x-1.5 items-center items-center"> |
There was a problem hiding this comment.
nit: seems like it was already in the code, but duplicate items-center and extraneous gap-y-1
Weves
force-pushed
the
fix-curator-role-issue
branch
from
a4e2be9 to
7331ef7
Compare
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizing the fetching of user