Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix Fix #3613

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Prefix Fix #3613

merged 1 commit into from
Jan 6, 2025

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Jan 6, 2025

Description

  • Prevent duplicate auth prefixes. SAML router prefix should be defined within server file.

How Has This Been Tested?

  • Spin up SAML on main- observe RuntimeError: Did not find user dependency in private route - APIRoute(path='/auth/saml/auth/saml/authorize', name='saml_login', methods=['GET'])
  • Spin up with this code- observe fix

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 5:16pm

@rkuo-danswer rkuo-danswer enabled auto-merge January 6, 2025 17:20
@rkuo-danswer rkuo-danswer added this pull request to the merge queue Jan 6, 2025
Merged via the queue into main with commit f16ca1b Jan 6, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants