Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom install path behaviour #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

neclimdul
Copy link

Fixes #26

@ivantcholakov
Copy link

ivantcholakov commented Nov 30, 2020

I tried this correction, it worked with Composer version 2.0.7:

    public function getLocations()
    {
        return [ '' => false ];
    }

Edit: Works on Composer 2.0.8 too.

@exteon
Copy link

exteon commented Dec 3, 2020

Bump, I need to fix the same issue here

ivantcholakov added a commit to ivantcholakov/starter-public-edition-4 that referenced this pull request Dec 7, 2020
@zaporylie
Copy link

Any chance to get this into tagged release? This is the only blocker for all my projects to fully immerse into composer 2 and for some reason patch is not applied (with cweagans/composer-patches) before the issue occurs when composer 2 is in use, however patching works when composer 1 is in use. I suspect some issue with plugin weights.

@neclimdul
Copy link
Author

I think this hasn't been merged because there was a suggestion for a slightly different approach on the main issue. A slightly deeper change to how things work that I haven't had time to rationalize and modify this merge.

#26 (comment)

If someone wants to do that might get things moving again.

@neclimdul neclimdul force-pushed the fix-custom-installer branch from 5f9f2b7 to 4d43a0c Compare April 15, 2021 15:10
@syzygy333
Copy link
Contributor

#26 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package type "library" is not supported
5 participants