Fix plugin test #33
Open
Fix plugin test #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installer constructor fails because current composer checks and tries to remove disabled installers but ends up calling a method on the null returned by the mock. This mocks up the new method call though this could be prone to failures on future versions. The dangers of mocking things you don't own.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installer constructor fails because current composer checks and tries to
remove disabled installers but ends up calling a method on the null
returned by the mock. This mocks up the new method call though this
could be prone to failures on future versions. The dangers of mocking
things you don't own.