upgrade Python and dependencies #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @AdrianDsg Thank you for creating PR! |
|
Hi @opeco17, |
|
Hi @opeco17, |
|
Hi, @AdrianDsg I'm so sorry for the delay BTW, may I know if you want to maintain this project as a maintainer? |
|
Hi @opeco17, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @opeco17,
I just discovered this great project. I wondered if the project is still actively maintained as apparently there hasn't been much activity lately.
So I upgraded the dependencies I discovered. Starting with Python 3.7 which has reached it's end-of-life I moved on to the GitHub Actions (
checkout,setup-python, ...).I also replaced the deprecated
set-outputcommand. I then upgraded the pip dependencies usingpoetry up.Unfortunately the CI workflows testing this PR have failed.
I'd be very grateful if you would consider looking into this PR. This project has already been very helpful to me.