feat: add caching and telemetry options #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @opeco17,
I just found this interesting plugin for poetry. I'm a happy user of poetry since a few days. I also discovered
poetry upand tested it on this repo.After upgrading the pip requirements I read more about the
safetymodule. Apparently they enable telemetry by default. So I added an option to this plugin to disable this behaviour.I also learnt that the caching of the
PyUpdatabase used bysafetyis apparently disabled by default. So I also added a option to cache the database for 1 hour on the hard disk (they use a JSON file in~/.safety/cache.jsonsized ca. 130kb).Unfortunately I didn't manage to get the tests working :(