Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reporting status from Manifest function of AgentAddon #98

Open
ctron opened this issue May 25, 2022 · 4 comments
Open

Allow reporting status from Manifest function of AgentAddon #98

ctron opened this issue May 25, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@ctron
Copy link

ctron commented May 25, 2022

When the agent reconciles the target's state in the Manifest function, it might encounter an error, which at this moment doesn't allow it reconcile.

However, there seems to be no proper way to record this, other than returning an error, which will re-trigger the reconciliation.

I think it would be helpful if the agent could contribute to the conditions of the ManagedClusterAddOn resource.

@qiujian16
Copy link
Member

/kind enhancement

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@qiujian16: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

/kind enhancement

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiujian16 qiujian16 added the enhancement New feature or request label Jun 8, 2022
@qiujian16
Copy link
Member

hrm, I think it makes sense. we need to think also whether directly return error make sense since it triggers reconcile and it is highly possible to return error again.

@ctron
Copy link
Author

ctron commented Jun 13, 2022

Maybe there can be two kinds of errors: temporary error (which re-trieggers) and permanent error (which does not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants