Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update condition when call manifest failed #101

Merged

Conversation

qiujian16
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from deads2k and elgnay June 8, 2022 08:53
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 8, 2022
also upgrade library and change to use patch condition

Signed-off-by: Jian Qiu <[email protected]>
@qiujian16 qiujian16 changed the title Condition update Update condition when call manifest failed Jun 8, 2022
@qiujian16
Copy link
Member Author

fixes #98

@zhujian7
Copy link
Member

@qiujian16 The e2e failed, please take a look

Signed-off-by: Jian Qiu <[email protected]>
@qiujian16
Copy link
Member Author

e2e is fixed.

@zhujian7
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2022
@openshift-ci openshift-ci bot merged commit 808b6fe into open-cluster-management-io:main Jun 14, 2022
@qiujian16 qiujian16 deleted the condition-update branch June 14, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants