Address code review comments

Signed-off-by: zhujian <[email protected]>
open-cluster-management-io · Nov 20, 2024 · ab3be60 · ab3be60
1 parent ff0a233
commit ab3be60
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 11 deletions.
diff --git a/addon/v1alpha1/0000_03_addon.open-cluster-management.io_addontemplates.crd.yaml b/addon/v1alpha1/0000_03_addon.open-cluster-management.io_addontemplates.crd.yaml
@@ -222,9 +222,6 @@ spec:
                             - type
                             type: object
                           type: array
-                          x-kubernetes-list-map-keys:
-                          - type
-                          x-kubernetes-list-type: map
                         resourceIdentifier:
                           description: |-
                             ResourceIdentifier represents the group, resource, name and namespace of a resoure.

diff --git a/work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml b/work/v1/0000_00_work.open-cluster-management.io_manifestworks.crd.yaml
@@ -206,9 +206,6 @@ spec:
                         - type
                         type: object
                       type: array
-                      x-kubernetes-list-map-keys:
-                      - type
-                      x-kubernetes-list-type: map
                     resourceIdentifier:
                       description: |-
                         ResourceIdentifier represents the group, resource, name and namespace of a resoure.

diff --git a/work/v1/types.go b/work/v1/types.go
@@ -94,8 +94,6 @@ type ManifestConfigOption struct {
 
 	// FeedbackRules defines what resource status field should be returned. If it is not set or empty,
 	// no feedback rules will be honored.
-	// +listType:=map
-	// +listMapKey:=type
 	// +optional
 	FeedbackRules []FeedbackRule `json:"feedbackRules,omitempty"`
 

diff --git a/work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml b/work/v1alpha1/0000_00_work.open-cluster-management.io_manifestworkreplicasets.crd.yaml
@@ -229,9 +229,6 @@ spec:
                             - type
                             type: object
                           type: array
-                          x-kubernetes-list-map-keys:
-                          - type
-                          x-kubernetes-list-type: map
                         resourceIdentifier:
                           description: |-
                             ResourceIdentifier represents the group, resource, name and namespace of a resoure.