Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 combine the sender and receiver to one client #282

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Sep 18, 2023

Summary

combine the sender and receiver to one client

@openshift-ci openshift-ci bot requested review from deads2k and qiujian16 September 18, 2023 02:04
@skeeey
Copy link
Member Author

skeeey commented Sep 18, 2023

/assign @qiujian16

@skeeey
Copy link
Member Author

skeeey commented Sep 18, 2023

/assign @yanmxa

Copy link
Member

@qiujian16 qiujian16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
@yanmxa pls take a look

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yanmxa
Copy link
Member

yanmxa commented Sep 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit d0a4952 into open-cluster-management-io:main Sep 19, 2023
9 checks passed
@skeeey skeeey deleted the cloudevents-combine-clients branch September 27, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants