Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix the nil pointer error when ProgressivePerGroup is not defined #295

Merged
merged 1 commit into from
Nov 14, 2023
Merged

🐛 fix the nil pointer error when ProgressivePerGroup is not defined #295

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cluster/v1alpha1/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,8 +195,8 @@ func (r *RolloutHandler[T]) getProgressivePerGroupClusters(rolloutStrategy Rollo
if strategy.ProgressivePerGroup == nil {
strategy.ProgressivePerGroup = &RolloutProgressivePerGroup{}
}
minSuccessTime := rolloutStrategy.ProgressivePerGroup.MinSuccessTime.Duration
maxFailures := rolloutStrategy.ProgressivePerGroup.MaxFailures
minSuccessTime := strategy.ProgressivePerGroup.MinSuccessTime.Duration
maxFailures := strategy.ProgressivePerGroup.MaxFailures

// Parse timeout for non-mandatory decision groups
failureTimeout, err := parseTimeout(strategy.ProgressivePerGroup.ProgressDeadline)
Expand Down
Loading