✨ add grpc option for cloudevents client. #302
Conversation
morvencao
force-pushed
the
br_cloudevents_grpc_option
branch
from
e71019b to
69ae49a
Compare
morvencao
force-pushed
the
br_cloudevents_grpc_option
branch
from
69ae49a to
95fdc0a
Compare
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_cloudevents_grpc_option
branch
from
95fdc0a to
1672cbe
Compare
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_cloudevents_grpc_option
branch
from
06fad7a to
22d3898
Compare
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_cloudevents_grpc_option
branch
from
22d3898 to
55c9f2c
Compare
| return &GRPCOptions{} | ||
| } | ||
|
|
||
| func (o *GRPCOptions) AddFlags(flags *pflag.FlagSet) { |
There was a problem hiding this comment.
I think this should also be in the config similar as mqtt. It will be better it we share the same config file.
There was a problem hiding this comment.
updated the grpc options to use config similar to mqtt.
Signed-off-by: morvencao <[email protected]>
|
|
||
| package io.cloudevents.v1; | ||
|
|
||
| option go_package = "open-cluster-management.io/api/cloudevents/generic/options/grpc/protobuf/v1"; |
There was a problem hiding this comment.
what is needed if the protobuf message is changed? We need some readme to explain.
There was a problem hiding this comment.
added a readme file and some comments to guide developer how to update go code after modifying the proto file.
Signed-off-by: morvencao <[email protected]>
| "open-cluster-management.io/api/cloudevents/generic/options/grpc/protocol" | ||
| ) | ||
|
|
||
| const ( |
There was a problem hiding this comment.
move these topics to a common file?
There was a problem hiding this comment.
Currently, the topic structure for gRPC aligns with MQTT, but when we have a third option like Kafka, that would need a distinct pattern for topics. In that case, a common file for topics becomes unfeasible, make sense?
There was a problem hiding this comment.
yeah, but I think the ideal situation is to have unified topics :), we can keep the topics in each option firstly
There was a problem hiding this comment.
OK, let's organize topics within each option for now and and see if we can have a unified topics in the future.
| } | ||
|
|
||
| func (o *grpcAgentOptions) WithContext(ctx context.Context, evtCtx cloudevents.EventContext) (context.Context, error) { | ||
| eventType, err := types.ParseCloudEventsType(evtCtx.GetType()) |
There was a problem hiding this comment.
We require this information to assign the topic for event publish, and the topic will be included in the gRPC publish request, see:
api/cloudevents/generic/options/grpc/protobuf/v1/cloudevent.proto
Lines 68 to 73 in 3012fe5
| @@ -0,0 +1,30 @@ | |||
| # CloudEvent gRPC Protobuf Definitions | |||
There was a problem hiding this comment.
would you also link this in the https://github.com/open-cluster-management-io/api/blob/main/cloudevents/README.md, we have a client introduction in this doc, you can add a new option in the CloudEventsOptions, it provides ...
There was a problem hiding this comment.
Added grpc option to cloudevents/README.md
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_cloudevents_grpc_option
branch
from
94415ee to
1bc3d90
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: morvencao, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit a2f58d6
into
open-cluster-management-io:main
Summary
This PR tries to add gRPC option for cloudevents client.
Related issue(s)
Fixes #