🌱 remove timeout field in rolloutstrategy v1alpha1 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoqing0110
changed the title
|
/assign @qiujian16 |
qiujian16
reviewed
Jan 2, 2024
| @@ -64,6 +64,8 @@ type RolloutConfig struct { | |||
| MinSuccessTime metav1.Duration `json:"minSuccessTime,omitempty"` | |||
| // ProgressDeadline defines how long workload applier controller will wait for the workload to | |||
| // reach a successful state in the cluster. | |||
| // If the workload does not reach a successful state after ProgressDeadline, will stop waiting | |||
| // and proceed to next rollout. | |||
There was a problem hiding this comment.
it also depend on max failure. Actuall it will stop rolling unless maxFailure is larger than 0
There was a problem hiding this comment.
have updated the comments.
cluster/v1alpha1/helpers.go
Outdated
| @@ -293,6 +293,9 @@ func progressivePerCluster( | |||
|
|
|||
| // If there was a breach of MaxFailures, only handle clusters that have already had workload applied | |||
| if !failureBreach || failureBreach && status.Status != ToApply { | |||
| // The length of `rolloutClusters` will be compared with the target rollout size to determine whether to return or not. | |||
| // The `timeoutClusters` only records clusters that are timeout and is not used for comparison with the target rollout size. | |||
| // In other words, the timeouted clusters are skipped and continue rollout on other clusters. | |||
There was a problem hiding this comment.
depend on whether failure exceeds maxfailures
There was a problem hiding this comment.
have updated the comments.
Signed-off-by: haoqing0110 <[email protected]>
haoqing0110
force-pushed
the
br_rm-timeout
branch
from
af6d56c to
f2e7243
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ccd7a2d
into
open-cluster-management-io:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Timeout is duplicated with ProgressDeadline, remove and use ProgressDeadline instead.
Related issue(s)
Fixes #