-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 expose mqtt topics #312
🌱 expose mqtt topics #312
Conversation
/assign @qiujian16 |
/assign @morvencao |
Signed-off-by: Wei Liu <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skeeey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good.
grpc options should not need this, right?
grpc may not this. this only for mqtt to set the share topic |
or we add an option for mqtt using share topic instead of setting topic? |
// PubQoS is the QoS for publish, by default is 1 | ||
PubQoS *int `json:"pubQoS,omitempty" yaml:"pubQoS,omitempty"` | ||
// SubQoS is the Qos for subscribe, by default is 1 | ||
SubQoS *int `json:"subQoS,omitempty" yaml:"subQoS,omitempty"` | ||
|
||
// SpecTopic is a MQTT topic for resource spec, by default is sources/+/clusters/+/spec. | ||
SpecTopic string `json:"specTopic,omitempty" yaml:"specTopic,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about a topics struct and status/spect/statusResync in it. I feel like the struct will be reused by other messaging system
/close This pr will be opened on go-sdk repo |
Summary
Related issue(s)
Fixes #