Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 expose mqtt topics #312

Closed
wants to merge 1 commit into from
Closed

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Jan 10, 2024

Summary

Related issue(s)

Fixes #

@skeeey
Copy link
Member Author

skeeey commented Jan 10, 2024

/assign @qiujian16

@skeeey
Copy link
Member Author

skeeey commented Jan 10, 2024

/assign @morvencao

Signed-off-by: Wei Liu <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skeeey
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiujian16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@morvencao morvencao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good.
grpc options should not need this, right?

@skeeey
Copy link
Member Author

skeeey commented Jan 11, 2024

grpc may not this. this only for mqtt to set the share topic

@skeeey
Copy link
Member Author

skeeey commented Jan 11, 2024

or we add an option for mqtt using share topic instead of setting topic?

// PubQoS is the QoS for publish, by default is 1
PubQoS *int `json:"pubQoS,omitempty" yaml:"pubQoS,omitempty"`
// SubQoS is the Qos for subscribe, by default is 1
SubQoS *int `json:"subQoS,omitempty" yaml:"subQoS,omitempty"`

// SpecTopic is a MQTT topic for resource spec, by default is sources/+/clusters/+/spec.
SpecTopic string `json:"specTopic,omitempty" yaml:"specTopic,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about a topics struct and status/spect/statusResync in it. I feel like the struct will be reused by other messaging system

@skeeey
Copy link
Member Author

skeeey commented Jan 15, 2024

/close

This pr will be opened on go-sdk repo

@skeeey skeeey closed this Jan 15, 2024
@skeeey skeeey deleted the et branch January 17, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants