🌱 Set DefaultClusterSet default value to true in feature gate
#344
Conversation
Signed-off-by: Rokibul Hasan <[email protected]>
RokibulHasan7
changed the title
DefaultClusterSet default value to true in feature gateDefaultClusterSet default value to true in feature gate
|
/assign @qiujian16 |
| @@ -96,7 +96,7 @@ var DefaultSpokeRegistrationFeatureGates = map[featuregate.Feature]featuregate.F | |||
| // feature keys for registration hub controller. To add a new feature, define a key for it above and | |||
| // add it here. | |||
| var DefaultHubRegistrationFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{ | |||
| DefaultClusterSet: {Default: false, PreRelease: featuregate.Alpha}, | |||
| DefaultClusterSet: {Default: true, PreRelease: featuregate.Alpha}, | |||
There was a problem hiding this comment.
commonly alpha feature should be false by default, we would need to promote it to beta feature.
There was a problem hiding this comment.
I see AddonManagement is also an alpha feature, and it's set to True. any plans to make it beta?
There was a problem hiding this comment.
hrm, it is not desired to be still in alpha, it should also be promoted to beta.
There was a problem hiding this comment.
Should I promote both to beta?
There was a problem hiding this comment.
Think about it twice. Any reason why you want to enable it by default, do you want to always create the default clusterset or global clusterset?
There was a problem hiding this comment.
We're enabling the DefaultClusterSet from here
So, I think we can set Default true.
There was a problem hiding this comment.
hrm that makes sense. then after this is enabled by false, i think we can remove the code in https://github.com/open-cluster-management-io/ocm/blob/7fd733082f5cf4de1af969b2edc6da1c07f14904/pkg/operator/helpers/helpers.go#L76
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, RokibulHasan7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit db876bf
into
open-cluster-management-io:main
Summary
Related issue(s)
Fixes #