Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go version to 1.20. #164

Merged

Conversation

xuezhaojun
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot requested review from qiujian16 and yue9944882 June 5, 2023 02:56
@openshift-ci openshift-ci bot added the approved label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (366272a) 23.31% compared to head (2e984b4) 23.31%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   23.31%   23.31%           
=======================================
  Files           9        9           
  Lines        1175     1175           
=======================================
  Hits          274      274           
  Misses        885      885           
  Partials       16       16           
Flag Coverage Δ
unit 23.31% <62.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/proxyagent/agent/agent.go 88.59% <100.00%> (ø)
pkg/util/portforward.go 0.00% <0.00%> (ø)
...yserver/controllers/service_resolver_controller.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun force-pushed the upgrade-go-1.20 branch 3 times, most recently from 7302b46 to 7aafba9 Compare June 5, 2023 03:18
@xuezhaojun xuezhaojun changed the title Upgrade go version to 1.20. WIP:Upgrade go version to 1.20. Jun 5, 2023
@xuezhaojun xuezhaojun changed the title WIP:Upgrade go version to 1.20. Upgrade go version to 1.20. Oct 8, 2023
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qiujian16,xuezhaojun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 411824e into open-cluster-management-io:main Oct 9, 2023
8 checks passed
@xuezhaojun xuezhaojun deleted the upgrade-go-1.20 branch March 7, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants