Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add finalizer permission to cluster-proxy. #168

Merged

Conversation

xuezhaojun
Copy link
Member

Fixes: open-cluster-management-io/ocm#230

Error log:

E1008 07:15:14.237293 1 base_controller.go:159] "addon-deploy-controller" controller failed to sync "local-cluster/cluster-proxy", err: Operation cannot be fulfilled on managedclusteraddons.addon.open-cluster-management.io "cluster-proxy": the object has been modified; please apply your changes to the latest version and try again
E1008 07:15:14.247988 1 base_controller.go:159] "addon-deploy-controller" controller failed to sync "local-cluster/cluster-proxy", err: manifestworks.work.open-cluster-management.io "addon-cluster-proxy-deploy-0" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>
E1008

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (366272a) 23.31% compared to head (767d2fb) 23.31%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #168   +/-   ##
=======================================
  Coverage   23.31%   23.31%           
=======================================
  Files           9        9           
  Lines        1175     1175           
=======================================
  Hits          274      274           
  Misses        885      885           
  Partials       16       16           
Flag Coverage Δ
unit 23.31% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/proxyagent/agent/agent.go 88.59% <100.00%> (ø)
...yserver/controllers/service_resolver_controller.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qiujian16,xuezhaojun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 03b52f3 into open-cluster-management-io:main Oct 9, 2023
8 checks passed
@xuezhaojun xuezhaojun deleted the update-role branch October 11, 2023 01:14
zhujian7 pushed a commit to zhujian7/cluster-proxy that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster-Gateway Installation Issue
2 participants