Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: ANP dependencies to 0.1.6 #170

Conversation

xuezhaojun
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ffa4f5c) 23.31% compared to head (a92ff40) 23.39%.

Files Patch % Lines
...yserver/controllers/service_resolver_controller.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   23.31%   23.39%   +0.07%     
==========================================
  Files           9        9              
  Lines        1175     1171       -4     
==========================================
  Hits          274      274              
+ Misses        885      881       -4     
  Partials       16       16              
Flag Coverage Δ
unit 23.39% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun force-pushed the upgrade-anp-to-v0.1.6 branch from d4287eb to 3c87a77 Compare November 24, 2023 08:31
@xuezhaojun xuezhaojun force-pushed the upgrade-anp-to-v0.1.6 branch 5 times, most recently from ca4a2e8 to b677a1a Compare November 24, 2023 09:12
@xuezhaojun xuezhaojun force-pushed the upgrade-anp-to-v0.1.6 branch from b677a1a to a92ff40 Compare November 24, 2023 10:55
@xuezhaojun xuezhaojun closed this Nov 24, 2023
@xuezhaojun xuezhaojun reopened this Nov 24, 2023
@xuezhaojun xuezhaojun closed this Nov 24, 2023
@xuezhaojun xuezhaojun reopened this Nov 24, 2023
@xuezhaojun
Copy link
Member Author

/assign @qiujian16

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
Copy link

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qiujian16,xuezhaojun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8474972 into open-cluster-management-io:main Nov 27, 2023
21 of 23 checks passed
@xuezhaojun xuezhaojun deleted the upgrade-anp-to-v0.1.6 branch November 27, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants