Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cabundle #173

Conversation

zhiweiyin318
Copy link
Member

No description provided.

Signed-off-by: Zhiwei Yin <[email protected]>
@openshift-ci openshift-ci bot requested review from qiujian16 and xuezhaojun January 8, 2024 13:55
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86d392e) 23.87% compared to head (b2f7a5a) 23.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
- Coverage   23.87%   23.86%   -0.01%     
==========================================
  Files           9        9              
  Lines        1198     1194       -4     
==========================================
- Hits          286      285       -1     
+ Misses        894      892       -2     
+ Partials       18       17       -1     
Flag Coverage Δ
unit 23.86% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun
Copy link
Member

/lgtm

@xuezhaojun
Copy link
Member

/approve

Copy link

openshift-ci bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun, zhiweiyin318

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dc6d127 into open-cluster-management-io:main Jan 8, 2024
9 checks passed
@zhiweiyin318 zhiweiyin318 deleted the fix-cabundle-upstream branch January 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants