-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflows.(change the github action used for release) #179
Update workflows.(change the github action used for release) #179
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xuezhaojun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @zhujian7 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
=======================================
Coverage 23.86% 23.86%
=======================================
Files 9 9
Lines 1194 1194
=======================================
Hits 285 285
Misses 892 892
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
token: ${{ secrets.GITHUB_TOKEN }} | ||
body_path: /home/runner/work/changelog.txt | ||
files: | | ||
release/*.tgz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
release/*.tgz | |
go/src/open-cluster-management.io/cluster-proxy/release/*.tgz |
since the default working-directory is go/src/open-cluster-management.io/cluster-proxy, https://github.com/open-cluster-management-io/cluster-proxy/pull/179/files#diff-29d508c8d0fc8d2fc3ea8e21d26ed76072f2de9d4a031e3307d41711e219bb76R16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I removed the default path to align with other repo and be simpler
Signed-off-by: GitHub <[email protected]>
33c09a9
to
c61383e
Compare
/lgtm |
/unhold |
7491951
into
open-cluster-management-io:main
* Remove codecov token in actions. (#174) Signed-off-by: xuezhaojun <[email protected]> * Use k8s 1.29 client libs (#175) Signed-off-by: Tamal Saha <[email protected]> * Fix the verify error of logger. (#177) Signed-off-by: GitHub <[email protected]> * Upgrade chart version to 0.4.0. (#178) Signed-off-by: GitHub <[email protected]> * Update workflows. (#179) Signed-off-by: GitHub <[email protected]> * Simplify installer watchers (#180) Signed-off-by: Tamal Saha <[email protected]> * Remove unused code (#181) Signed-off-by: Tamal Saha <[email protected]> * Fix LB type proxy server setup in chart (#182) Signed-off-by: Tamal Saha <[email protected]> * Use default rollingout strategy. (#184) Signed-off-by: GitHub <[email protected]> * Add the hash value of signer into subject organizationunits (#183) Signed-off-by: GitHub <[email protected]> * Change examples to md format to reduce dependences. (#185) Signed-off-by: GitHub <[email protected]> * Update stolostronagent. Signed-off-by: GitHub <[email protected]> --------- Signed-off-by: xuezhaojun <[email protected]> Signed-off-by: Tamal Saha <[email protected]> Signed-off-by: GitHub <[email protected]> Co-authored-by: Tamal Saha <[email protected]>
Refer: the secrets.GITHUB_TOKEN https://docs.github.com/en/actions/security-guides/automatic-token-authentication