Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows.(change the github action used for release) #179

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Mar 7, 2024

@openshift-ci openshift-ci bot requested review from qiujian16 and yue9944882 March 7, 2024 03:33
Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 7, 2024
@xuezhaojun
Copy link
Member Author

/assign @zhujian7

@xuezhaojun xuezhaojun changed the title Update workflows. Update workflows.(change the github action used for release) Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.86%. Comparing base (503b71a) to head (c61383e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #179   +/-   ##
=======================================
  Coverage   23.86%   23.86%           
=======================================
  Files           9        9           
  Lines        1194     1194           
=======================================
  Hits          285      285           
  Misses        892      892           
  Partials       17       17           
Flag Coverage Δ
unit 23.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xuezhaojun xuezhaojun closed this Mar 7, 2024
@xuezhaojun xuezhaojun reopened this Mar 7, 2024
token: ${{ secrets.GITHUB_TOKEN }}
body_path: /home/runner/work/changelog.txt
files: |
release/*.tgz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
release/*.tgz
go/src/open-cluster-management.io/cluster-proxy/release/*.tgz

since the default working-directory is go/src/open-cluster-management.io/cluster-proxy, https://github.com/open-cluster-management-io/cluster-proxy/pull/179/files#diff-29d508c8d0fc8d2fc3ea8e21d26ed76072f2de9d4a031e3307d41711e219bb76R16

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I removed the default path to align with other repo and be simpler

Signed-off-by: GitHub <[email protected]>
@xuezhaojun xuezhaojun requested a review from zhujian7 March 7, 2024 06:57
@zhujian7
Copy link
Member

zhujian7 commented Mar 7, 2024

/lgtm
/hold

@xuezhaojun
Copy link
Member Author

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit 7491951 into open-cluster-management-io:main Mar 7, 2024
9 checks passed
@xuezhaojun xuezhaojun deleted the upgrade-workflows branch March 7, 2024 07:46
openshift-merge-bot bot referenced this pull request in stolostron/cluster-proxy Mar 20, 2024
* Remove codecov token in actions. (#174)

Signed-off-by: xuezhaojun <[email protected]>

* Use k8s 1.29 client libs (#175)

Signed-off-by: Tamal Saha <[email protected]>

* Fix the verify error of logger. (#177)

Signed-off-by: GitHub <[email protected]>

* Upgrade chart version to 0.4.0. (#178)

Signed-off-by: GitHub <[email protected]>

* Update workflows. (#179)

Signed-off-by: GitHub <[email protected]>

* Simplify installer watchers (#180)

Signed-off-by: Tamal Saha <[email protected]>

* Remove unused code (#181)

Signed-off-by: Tamal Saha <[email protected]>

* Fix LB type proxy server setup in chart (#182)

Signed-off-by: Tamal Saha <[email protected]>

* Use default rollingout strategy. (#184)

Signed-off-by: GitHub <[email protected]>

* Add the hash value of signer into subject organizationunits (#183)

Signed-off-by: GitHub <[email protected]>

* Change examples to md format to reduce dependences. (#185)

Signed-off-by: GitHub <[email protected]>

* Update stolostronagent.

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: xuezhaojun <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Tamal Saha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants