Simplify installer watchers #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamal Saha <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 23.86% 23.61% -0.26%
==========================================
Files 9 9
Lines 1194 1207 +13
==========================================
Hits 285 285
- Misses 892 905 +13
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/assign @xuezhaojun SGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, tamalsaha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit b0cc356
into
open-cluster-management-io:main
9 checks passed
openshift-merge-bot bot
referenced
this pull request
in stolostron/cluster-proxy
Mar 20, 2024
* Remove codecov token in actions. (#174) Signed-off-by: xuezhaojun <[email protected]> * Use k8s 1.29 client libs (#175) Signed-off-by: Tamal Saha <[email protected]> * Fix the verify error of logger. (#177) Signed-off-by: GitHub <[email protected]> * Upgrade chart version to 0.4.0. (#178) Signed-off-by: GitHub <[email protected]> * Update workflows. (#179) Signed-off-by: GitHub <[email protected]> * Simplify installer watchers (#180) Signed-off-by: Tamal Saha <[email protected]> * Remove unused code (#181) Signed-off-by: Tamal Saha <[email protected]> * Fix LB type proxy server setup in chart (#182) Signed-off-by: Tamal Saha <[email protected]> * Use default rollingout strategy. (#184) Signed-off-by: GitHub <[email protected]> * Add the hash value of signer into subject organizationunits (#183) Signed-off-by: GitHub <[email protected]> * Change examples to md format to reduce dependences. (#185) Signed-off-by: GitHub <[email protected]> * Update stolostronagent. Signed-off-by: GitHub <[email protected]> --------- Signed-off-by: xuezhaojun <[email protected]> Signed-off-by: Tamal Saha <[email protected]> Signed-off-by: GitHub <[email protected]> Co-authored-by: Tamal Saha <[email protected]>
tamalsaha
added a commit
to kluster-manager/cluster-proxy
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Tamal Saha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no real logical change here. I am just using the
EnqueueRequestsFromMapFuncmethod in controller-runtime to simplify the code.