Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default rollingout strategy. #184

Conversation

xuezhaojun
Copy link
Member

@xuezhaojun xuezhaojun commented Mar 15, 2024

We want to keep at least one running pod, the current configuration doesn't fit.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.61%. Comparing base (5a1f589) to head (3a2a3c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   23.61%   23.61%           
=======================================
  Files           9        9           
  Lines        1207     1207           
=======================================
  Hits          285      285           
  Misses        905      905           
  Partials       17       17           
Flag Coverage Δ
unit 23.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

Copy link

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, xuezhaojun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [qiujian16,xuezhaojun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 612fc69 into open-cluster-management-io:main Mar 15, 2024
9 checks passed
@xuezhaojun xuezhaojun deleted the use-default-rolling-update-strategy branch March 15, 2024 06:51
openshift-merge-bot bot referenced this pull request in stolostron/cluster-proxy Mar 20, 2024
* Remove codecov token in actions. (#174)

Signed-off-by: xuezhaojun <[email protected]>

* Use k8s 1.29 client libs (#175)

Signed-off-by: Tamal Saha <[email protected]>

* Fix the verify error of logger. (#177)

Signed-off-by: GitHub <[email protected]>

* Upgrade chart version to 0.4.0. (#178)

Signed-off-by: GitHub <[email protected]>

* Update workflows. (#179)

Signed-off-by: GitHub <[email protected]>

* Simplify installer watchers (#180)

Signed-off-by: Tamal Saha <[email protected]>

* Remove unused code (#181)

Signed-off-by: Tamal Saha <[email protected]>

* Fix LB type proxy server setup in chart (#182)

Signed-off-by: Tamal Saha <[email protected]>

* Use default rollingout strategy. (#184)

Signed-off-by: GitHub <[email protected]>

* Add the hash value of signer into subject organizationunits (#183)

Signed-off-by: GitHub <[email protected]>

* Change examples to md format to reduce dependences. (#185)

Signed-off-by: GitHub <[email protected]>

* Update stolostronagent.

Signed-off-by: GitHub <[email protected]>

---------

Signed-off-by: xuezhaojun <[email protected]>
Signed-off-by: Tamal Saha <[email protected]>
Signed-off-by: GitHub <[email protected]>
Co-authored-by: Tamal Saha <[email protected]>
xuezhaojun added a commit to xuezhaojun/cluster-proxy that referenced this pull request Dec 23, 2024
…-konflux-errors

Upgrade base image in backplane 2.7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants