Allow customize default install namespace from flag #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jian Qiu <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 23.39% 23.80% +0.40%
==========================================
Files 9 9
Lines 1013 1021 +8
==========================================
+ Hits 237 243 +6
- Misses 758 759 +1
- Partials 18 19 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 261e725
into
open-cluster-management-io:main
9 checks passed
qiujian16
added a commit
to qiujian16/cluster-proxy
that referenced
this pull request
May 21, 2024
…agement-io#195) Signed-off-by: Jian Qiu <[email protected]>
openshift-merge-bot bot
referenced
this pull request
in stolostron/cluster-proxy
May 22, 2024
* Update codecov action version to 4.2.0. (#188) Signed-off-by: GitHub <[email protected]> Signed-off-by: Jian Qiu <[email protected]> * Use codecov token. (#190) Signed-off-by: GitHub <[email protected]> Signed-off-by: Jian Qiu <[email protected]> * Remove codecov token in env. (#191) Signed-off-by: GitHub <[email protected]> Signed-off-by: Jian Qiu <[email protected]> * Change codecov key name. (#192) Signed-off-by: GitHub <[email protected]> Signed-off-by: Jian Qiu <[email protected]> * support install ns from addonDeploymentConfig (#194) * Support install namespace and remove installAll Signed-off-by: Jian Qiu <[email protected]> * Support addon install ns from addonDeploymentConfig Signed-off-by: Jian Qiu <[email protected]> --------- Signed-off-by: Jian Qiu <[email protected]> * Allow customize default install namespace from flag (#195) Signed-off-by: Jian Qiu <[email protected]> * Support install ns in stolstron cluster-proxy Signed-off-by: Jian Qiu <[email protected]> --------- Signed-off-by: GitHub <[email protected]> Signed-off-by: Jian Qiu <[email protected]> Co-authored-by: xuezhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.