🌱 Deprecate managedserviceaccount v1alpha1 (#92)

* Deprecate managedserviceaccount v1alpha1 Signed-off-by: zhujian <[email protected]> * Add deprecation warning Signed-off-by: zhujian <[email protected]> --------- Signed-off-by: zhujian <[email protected]>
open-cluster-management-io · Jan 3, 2024 · 6b87ce3 · 6b87ce3
1 parent 051c36f
commit 6b87ce3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 7 deletions.
diff --git a/apis/authentication/v1alpha1/managedserviceaccount_types.go b/apis/authentication/v1alpha1/managedserviceaccount_types.go
@@ -26,7 +26,7 @@ func init() {
 
 //+kubebuilder:object:root=true
 //+kubebuilder:subresource:status
-//+kubebuilder:storageversion
+//+kubebuilder:deprecatedversion:warning="authentication.open-cluster-management.io/v1alpha1 ManagedServiceAccount is deprecated; use authentication.open-cluster-management.io/v1beta1 ManagedServiceAccount; version v1alpha1 will be removed in the next release"
 
 // +genclient
 // ManagedServiceAccount is the Schema for the managedserviceaccounts API

diff --git a/apis/authentication/v1beta1/managedserviceaccount_types.go b/apis/authentication/v1beta1/managedserviceaccount_types.go
@@ -26,6 +26,7 @@ func init() {
 
 //+kubebuilder:object:root=true
 //+kubebuilder:subresource:status
+//+kubebuilder:storageversion
 
 // +genclient
 // ManagedServiceAccount is the Schema for the managedserviceaccounts API

diff --git a/...serviceaccount/crds/authentication.open-cluster-management.io_managedserviceaccounts.yaml b/...serviceaccount/crds/authentication.open-cluster-management.io_managedserviceaccounts.yaml
@@ -16,7 +16,11 @@ spec:
     singular: managedserviceaccount
   scope: Namespaced
   versions:
-  - name: v1alpha1
+  - deprecated: true
+    deprecationWarning: authentication.open-cluster-management.io/v1alpha1 ManagedServiceAccount
+      is deprecated; use authentication.open-cluster-management.io/v1beta1 ManagedServiceAccount;
+      version v1alpha1 will be removed in the next release
+    name: v1alpha1
     schema:
       openAPIV3Schema:
         description: ManagedServiceAccount is the Schema for the managedserviceaccounts
@@ -167,7 +171,7 @@ spec:
             type: object
         type: object
     served: true
-    storage: true
+    storage: false
     subresources:
       status: {}
   - name: v1beta1
@@ -321,7 +325,7 @@ spec:
             type: object
         type: object
     served: true
-    storage: false
+    storage: true
     subresources:
       status: {}
 status:

diff --git a/config/crd/bases/authentication.open-cluster-management.io_managedserviceaccounts.yaml b/config/crd/bases/authentication.open-cluster-management.io_managedserviceaccounts.yaml
@@ -16,7 +16,11 @@ spec:
     singular: managedserviceaccount
   scope: Namespaced
   versions:
-  - name: v1alpha1
+  - deprecated: true
+    deprecationWarning: authentication.open-cluster-management.io/v1alpha1 ManagedServiceAccount
+      is deprecated; use authentication.open-cluster-management.io/v1beta1 ManagedServiceAccount;
+      version v1alpha1 will be removed in the next release
+    name: v1alpha1
     schema:
       openAPIV3Schema:
         description: ManagedServiceAccount is the Schema for the managedserviceaccounts
@@ -167,7 +171,7 @@ spec:
             type: object
         type: object
     served: true
-    storage: true
+    storage: false
     subresources:
       status: {}
   - name: v1beta1
@@ -321,7 +325,7 @@ spec:
             type: object
         type: object
     served: true
-    storage: false
+    storage: true
     subresources:
       status: {}
 status: