Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Build all hub controller as a single controller #683

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qiujian16
Copy link
Member

Summary

Related issue(s)

Fixes #

@openshift-ci openshift-ci bot requested review from elgnay and skeeey October 31, 2024 07:15
Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 1.26582% with 156 lines in your changes missing coverage. Please review.

Project coverage is 63.08%. Comparing base (26f9e74) to head (37c23ec).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/singleton/hub/manager.go 0.00% 137 Missing ⚠️
pkg/cmd/hub/operator.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   63.04%   63.08%   +0.03%     
==========================================
  Files         182      183       +1     
  Lines       17622    17790     +168     
==========================================
+ Hits        11110    11223     +113     
- Misses       5600     5636      +36     
- Partials      912      931      +19     
Flag Coverage Δ
unit 63.08% <1.26%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant