Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support cel selector #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haoqing0110
Copy link
Member

Summary

Related issue(s)

Fixes #

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 81.00000% with 38 lines in your changes missing coverage. Please review.

Project coverage is 63.96%. Comparing base (9eb8131) to head (fc97656).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
pkg/placement/helpers/cel.go 84.04% 21 Missing and 9 partials ⚠️
...nt/controllers/scheduling/scheduling_controller.go 11.11% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   63.33%   63.96%   +0.62%     
==========================================
  Files         187      193       +6     
  Lines       17921    18796     +875     
==========================================
+ Hits        11351    12022     +671     
- Misses       5635     5783     +148     
- Partials      935      991      +56     
Flag Coverage Δ
unit 63.96% <81.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metav1.LabelSelector `json:",inline"`

// +optional
RegexSelector map[string]string `json:"regexSelector,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider a CEL based selector, which could be more flexible.
e.g. could reference a score value

Copy link
Contributor

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haoqing0110
Once this PR has been reviewed and has the lgtm label, please assign qiujian16 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@haoqing0110 haoqing0110 changed the title WIP: support regex selector WIP: support cel selector Dec 13, 2024
@haoqing0110 haoqing0110 force-pushed the br_regex branch 2 times, most recently from c9d29d9 to 41396ee Compare December 17, 2024 09:30
Signed-off-by: Qing Hao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants