Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy to setup download of PolicyGenerator from hub #440

Conversation

brian-jarvis
Copy link
Contributor

It was discussed in https://issues.redhat.com/browse/ACM-8945 to remove the PolicyGenerator version from the RHACM documentation.

Removing this from the documentation has a side effect in that the customer would not know which version to download. Additionally since the only published location is upstream what they are downloading to run locally does not have a guarantee to be a functional match since RHACM PolicyGenerator is not built from upstream repos.

https://access.redhat.com/articles/7049658 was written to showcase using policies how to configure a ConsoleCLIDownload on the hub cluster to expose the PolicyGenerator included with the running RHACM Operator.

This policy submission is the code and PolicyGenerator used to create the article.

Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great--thanks for contributing this!

I have some minor comments for consideration.

@brian-jarvis brian-jarvis force-pushed the ACM-8945-PolicyGenerator-Download branch from f6b5c52 to d03de8f Compare December 21, 2023 20:01
@brian-jarvis brian-jarvis force-pushed the ACM-8945-PolicyGenerator-Download branch from d03de8f to 7d8ab5a Compare December 21, 2023 20:51
@brian-jarvis brian-jarvis force-pushed the ACM-8945-PolicyGenerator-Download branch from 7d8ab5a to 44d7943 Compare December 21, 2023 20:55
Copy link
Member

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!!!

@openshift-ci openshift-ci bot added the lgtm label Dec 21, 2023
Copy link

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brian-jarvis, dhaiducek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 60035db into open-cluster-management-io:main Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants