Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pvc label name #446

Merged

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented Jan 22, 2024

https://issues.redhat.com/browse/ACM-9503

Changes:

  • Rename PVC backup label to cluster.open-cluster-management.io/backup-pvc
  • restore restic secret and user defined pvc config at cluster activation time
  • on backup, create the volsync-config-pvcs ConfigMap only if any PVC resource with backup label
  • update check on SourceReplication to check if corresponding PV still has the volsync label ( should remove the SourceReplication otherwise )

Signed-off-by: Valentina Birsan <[email protected]>
@birsanv
Copy link
Contributor Author

birsanv commented Jan 22, 2024

/hold

Signed-off-by: Valentina Birsan <[email protected]>
@birsanv
Copy link
Contributor Author

birsanv commented Jan 23, 2024

/un-hold

Copy link

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, gparvin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@birsanv
Copy link
Contributor Author

birsanv commented Jan 23, 2024

/unhold

@openshift-merge-bot openshift-merge-bot bot merged commit e154fa8 into open-cluster-management-io:main Jan 23, 2024
3 checks passed
@birsanv birsanv deleted the vb_volsync_0122 branch January 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants