-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to install openshift gitops argocd and include health #460
Make it easier to install openshift gitops argocd and include health #460
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
LGTM! At least, I couldn't see any issues, I figure you developed this from testing.
Just holding because it's been open 2 weeks and I don't want to surprise-merge it, feel free to unhold if it is good to go.
it is not used by ArgoCD. Thanks a lot, create idea to add healthchecks |
Creating a policy set to make setup of openshift gitops easier. It sets up the generator and configures health checks for policies. Signed-off-by: Gus Parvin <[email protected]>
Thanks, I think it was a copy paste carry over from setting up the project. I have removed the file which wasn't used. |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
de57887
into
open-cluster-management-io:main
Creating a policy set to make setup of openshift gitops easier. It sets up the generator and configures health checks for policies.