Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to install openshift gitops argocd and include health #460

Merged

Conversation

gparvin
Copy link
Member

@gparvin gparvin commented Mar 5, 2024

Creating a policy set to make setup of openshift gitops easier. It sets up the generator and configures health checks for policies.

JustinKuli
JustinKuli previously approved these changes Mar 18, 2024
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

LGTM! At least, I couldn't see any issues, I figure you developed this from testing.

Just holding because it's been open 2 weeks and I don't want to surprise-merge it, feel free to unhold if it is good to go.

@ch-stark
Copy link
Contributor

Creating a policy set to make setup of openshift gitops easier. It
sets up the generator and configures health checks for policies.

Signed-off-by: Gus Parvin <[email protected]>
@gparvin
Copy link
Member Author

gparvin commented Mar 19, 2024

it is not used by ArgoCD. Thanks a lot, create idea to add healthchecks

Thanks, I think it was a copy paste carry over from setting up the project. I have removed the file which wasn't used.

@gparvin gparvin requested a review from JustinKuli May 9, 2024 13:51
@gparvin
Copy link
Member Author

gparvin commented May 9, 2024

/unhold

@openshift-ci openshift-ci bot added the lgtm label May 9, 2024
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gparvin, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit de57887 into open-cluster-management-io:main May 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants