-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert existing policies to operator policies for installing operators #467
Convert existing policies to operator policies for installing operators #467
Conversation
Rebasing then opening it as ready for review. |
/hold until OperatorPolicy is GA |
/unhold |
@zyjjay could you please rebase this PR? |
Seems like |
subscription: | ||
name: compliance-operator | ||
namespace: openshift-compliance | ||
installPlanApproval: Automatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zyjjay this is no longer the field to set in the latest release. This was replaced with spec.upgradeApproval
.
subscription: | ||
name: compliance-operator | ||
namespace: openshift-compliance | ||
upgradeApproval: Automatic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
upgradeApproval is not at the subscription level. It should be up a level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch 😅
Converted policies: - Compliance operator policy - Quay container security operator policy - Gatekeeper operator policy ref: https://issues.redhat.com/browse/ACM-10573 Signed-off-by: Jason Zhang <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, zyjjay The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b39d4a5
into
open-cluster-management-io:main
Converted policies:
ref: https://issues.redhat.com/browse/ACM-10573