Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert existing policies to operator policies for installing operators #467

Merged

Conversation

zyjjay
Copy link
Contributor

@zyjjay zyjjay commented Apr 17, 2024

Converted policies:

  • Compliance operator policy
  • Quay container security operator policy
  • Gatekeeper operator policy

ref: https://issues.redhat.com/browse/ACM-10573

@zyjjay
Copy link
Contributor Author

zyjjay commented May 14, 2024

Rebasing then opening it as ready for review.

@zyjjay zyjjay marked this pull request as ready for review May 14, 2024 20:09
@openshift-ci openshift-ci bot requested review from dhaiducek and mprahl May 14, 2024 20:09
@mprahl
Copy link
Member

mprahl commented May 14, 2024

/hold until OperatorPolicy is GA

@mprahl
Copy link
Member

mprahl commented Aug 13, 2024

/unhold

@mprahl
Copy link
Member

mprahl commented Aug 13, 2024

@zyjjay could you please rebase this PR?

@zyjjay
Copy link
Contributor Author

zyjjay commented Aug 13, 2024

Seems like placementrule and placementbinding are deprecated here. I'll go ahead and remove them from these operator policies as well.

subscription:
name: compliance-operator
namespace: openshift-compliance
installPlanApproval: Automatic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyjjay this is no longer the field to set in the latest release. This was replaced with spec.upgradeApproval.

subscription:
name: compliance-operator
namespace: openshift-compliance
upgradeApproval: Automatic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upgradeApproval is not at the subscription level. It should be up a level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch 😅

Converted policies:
- Compliance operator policy
- Quay container security operator policy
- Gatekeeper operator policy

ref: https://issues.redhat.com/browse/ACM-10573
Signed-off-by: Jason Zhang <[email protected]>
Copy link

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, zyjjay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b39d4a5 into open-cluster-management-io:main Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants