Configure machine sets to work with multiple platforms, adding vmware #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiraeChristineKim
previously approved these changes
Apr 26, 2024
This adds a vmware machine set that will help customers learn how to easily setup OPP in different environments. This setup is intended to work with the QE interop vmware environment. Feedback welcome on this since I don't have a vmware environment to directly work with. Signed-off-by: Gus Parvin <[email protected]>
gparvin
force-pushed
the
vmware-machineset
branch
from
b61e4f6 to
afe4a1e
Compare
gparvin
changed the title
|
The machines/nodes were properly created. I just had to increase the replicas in my latest change. |
yiraeChristineKim
approved these changes
Apr 26, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit feb6011
into
open-cluster-management-io:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a vmware machine set that will help customers learn how to easily setup OPP in different environments. This setup is intended to work with the QE interop vmware environment. Feedback welcome on this since I don't have a vmware environment to directly work with.