Increase memory and CPU so OPP products will install #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
previously approved these changes
Apr 26, 2024
gparvin
force-pushed
the
vmware-resources
branch
from
34e2edd to
e2b3539
Compare
gparvin
changed the title
|
I moved the values to the configmap for aws and vmware. This is ready for another look. |
dhaiducek
reviewed
May 9, 2024
| @@ -1,10 +1,14 @@ | |||
| # This manifest creates 3 OpenShift MachineSets that are intended for installing OpenShift Cluster Storage on AWS. | |||
| # This manifest creates storage nodes necessary for installing OPP on an AWS or VMWare OpenShift cluster. | |||
| # - AWS creates 2 replices in each of 3 zones. | |||
There was a problem hiding this comment.
Suggested change
| # - AWS creates 2 replices in each of 3 zones. | |
| # - AWS creates 2 replicas in each of 3 zones. |
Comment on lines
2
to
28
| data: | ||
| vmwareReplicas: "6" | ||
| vmwareCPU: "8" | ||
| vmwareMemory: "32768" | ||
| awsReplicas: "2" | ||
| awsInstanceType: m6a.2xlarge | ||
| us-east-1-4.10: ami-0c72f473496a7b1c2 | ||
| us-east-1-4.11: ami-0722eb0819717090f | ||
| us-east-1-4.12: ami-0fe05b1aa8dacfa90 | ||
| us-east-1-4.13: ami-0624891c612b5eaa0 | ||
| us-east-1-4.14: ami-0b56cb92505dea7ed | ||
| us-east-1-4.15: ami-0b56cb92505dea7ed | ||
| us-east-1-4.16: ami-057df4d0cb8cbae0d | ||
| us-east-2-4.10: ami-09e637fc5885c13cc | ||
| us-east-2-4.11: ami-026e5701f495c94a2 | ||
| us-east-2-4.12: ami-0ff64f495c7e977cf | ||
| us-east-2-4.13: ami-0dc6c4d1bd5161f13 | ||
| us-east-2-4.14: ami-0dc6c4d1bd5161f13 | ||
| us-east-2-4.15: ami-0b577c67f5371f6d1 | ||
| us-east-2-4.16: ami-0f736c64d5751d7d3 | ||
| zone1: a | ||
| zone2: b | ||
| zone3: c | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: opp-settings | ||
| namespace: policies |
There was a problem hiding this comment.
nit: Moved the metadata to the top. I find the alphabetical field ordering unconventional.
Suggested change
| data: | |
| vmwareReplicas: "6" | |
| vmwareCPU: "8" | |
| vmwareMemory: "32768" | |
| awsReplicas: "2" | |
| awsInstanceType: m6a.2xlarge | |
| us-east-1-4.10: ami-0c72f473496a7b1c2 | |
| us-east-1-4.11: ami-0722eb0819717090f | |
| us-east-1-4.12: ami-0fe05b1aa8dacfa90 | |
| us-east-1-4.13: ami-0624891c612b5eaa0 | |
| us-east-1-4.14: ami-0b56cb92505dea7ed | |
| us-east-1-4.15: ami-0b56cb92505dea7ed | |
| us-east-1-4.16: ami-057df4d0cb8cbae0d | |
| us-east-2-4.10: ami-09e637fc5885c13cc | |
| us-east-2-4.11: ami-026e5701f495c94a2 | |
| us-east-2-4.12: ami-0ff64f495c7e977cf | |
| us-east-2-4.13: ami-0dc6c4d1bd5161f13 | |
| us-east-2-4.14: ami-0dc6c4d1bd5161f13 | |
| us-east-2-4.15: ami-0b577c67f5371f6d1 | |
| us-east-2-4.16: ami-0f736c64d5751d7d3 | |
| zone1: a | |
| zone2: b | |
| zone3: c | |
| kind: ConfigMap | |
| metadata: | |
| name: opp-settings | |
| namespace: policies | |
| kind: ConfigMap | |
| metadata: | |
| name: opp-settings | |
| namespace: policies | |
| data: | |
| vmwareReplicas: "6" | |
| vmwareCPU: "8" | |
| vmwareMemory: "32768" | |
| awsReplicas: "2" | |
| awsInstanceType: m6a.2xlarge | |
| us-east-1-4.10: ami-0c72f473496a7b1c2 | |
| us-east-1-4.11: ami-0722eb0819717090f | |
| us-east-1-4.12: ami-0fe05b1aa8dacfa90 | |
| us-east-1-4.13: ami-0624891c612b5eaa0 | |
| us-east-1-4.14: ami-0b56cb92505dea7ed | |
| us-east-1-4.15: ami-0b56cb92505dea7ed | |
| us-east-1-4.16: ami-057df4d0cb8cbae0d | |
| us-east-2-4.10: ami-09e637fc5885c13cc | |
| us-east-2-4.11: ami-026e5701f495c94a2 | |
| us-east-2-4.12: ami-0ff64f495c7e977cf | |
| us-east-2-4.13: ami-0dc6c4d1bd5161f13 | |
| us-east-2-4.14: ami-0dc6c4d1bd5161f13 | |
| us-east-2-4.15: ami-0b577c67f5371f6d1 | |
| us-east-2-4.16: ami-0f736c64d5751d7d3 | |
| zone1: a | |
| zone2: b | |
| zone3: c |
There was a problem hiding this comment.
ok, i fixed that too. Thanks!
The attempt to install OPP failed because more CPU and Memory was needed. Increasing vmware resources to match what AWS uses. The adjustments to the configmap usage had to be re-organized too, since the configmap needs to exist ahead of time to resolve the template values. Referenced bug: - https://issues.redhat.com/browse/OCPQE-21328 Signed-off-by: Gus Parvin <[email protected]>
dhaiducek
approved these changes
May 9, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, gparvin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f59e3b5
into
open-cluster-management-io:main
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The attempt to install OPP failed because more CPU and Memory was needed. Increasing resources to match what AWS uses.
Running a test with this PR to see if it resolves the resource issue.