Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update policies and readme #475

Merged
merged 1 commit into from
May 9, 2024
Merged

update policies and readme #475

merged 1 commit into from
May 9, 2024

Conversation

birsanv
Copy link
Contributor

@birsanv birsanv commented May 8, 2024 •
edited
Loading

https://issues.redhat.com/browse/ACM-10745

Updated policies with the following changes :

  • allow restoring Snapshots from a different location
  • allow customizing a ReplicationDestination configuration
  • add more optional hub-pvc-backup properties
  • updated readme

@birsanv
update policies and readme
4c2d3a0 
Signed-off-by: Valentina Birsan <[email protected]>
@openshift-ci openshift-ci bot requested review from JustinKuli and mprahl May 8, 2024 17:01
@birsanv birsanv mentioned this pull request May 8, 2024
Merged
13 tasks
@birsanv
Copy link
Contributor Author

birsanv commented May 8, 2024

/cc @tesshuflower

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

@birsanv: GitHub didn't allow me to request PR reviews from the following users: tesshuflower.

Note that only open-cluster-management-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tesshuflower

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tesshuflower
tesshuflower approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@tesshuflower tesshuflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 8, 2024

@tesshuflower: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm label May 9, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, gparvin, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 160924e into open-cluster-management-io:main May 9, 2024
3 checks passed
@magic-mirror-bot magic-mirror-bot bot mentioned this pull request May 9, 2024
Merged
@birsanv birsanv deleted the vb_pv_backup branch May 9, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tesshuflower tesshuflower tesshuflower approved these changes

@gparvin gparvin gparvin approved these changes

@JustinKuli JustinKuli Awaiting requested review from JustinKuli

@mprahl mprahl Awaiting requested review from mprahl

Assignees

@gparvin gparvin

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birsanv @gparvin @tesshuflower