Validate method for oci/ocm repository specs #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilmarf
reviewed
Aug 12, 2024
hilmarf
reviewed
Aug 12, 2024
hilmarf
requested changes
Aug 12, 2024
hilmarf
previously approved these changes
Aug 16, 2024
hilmarf
approved these changes
Aug 23, 2024
hilmarf
pushed a commit
that referenced
this pull request
Sep 11, 2024
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it This fixes up the validate methods setup in #866 so that we dont run into surprises later on. Shouldnt affect anything right now since we actually dont have any consuming repo implementations of this right now. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a
Validatemethod for OCI and OCM repository specifications.Its task is to validate the spec as well as the connectivity (and potentially the credentials), if possible.
Checking credentials makes only sense, if there is no possibility to use different credentials for different shards
of the repository (for example organizations in the GitHub OCI registry).