introduce optional repository interface for resolvers #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
changed the title
hilmarf
reviewed
Aug 12, 2024
hilmarf
reviewed
Aug 12, 2024
hilmarf
reviewed
Aug 12, 2024
hilmarf
requested changes
Aug 12, 2024
hilmarf
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CLI command
ocm list componentversionsdumps if only a component is specified together with a resolver (either as part of the config or as option).This PR fixes this dump.
The resolvers are only able to resolve component versions. Therefore, after the fix the provided list does not show any version for the given component. The expected behaviour would surely be to get the list of versions resolvable by the given resolvers.
Not all resolvers are able to provide repositories offering a version list method. Therefore an optional interface is introduced for
resolvers, which provide potential repositories for a given component. This interface offers the possibility to return repositories or abstract component providers which can be used to get versions or version lists.
This is then checked by the list handling to gather versions provided by all found repositories.
Which issue(s) this PR fixes:
Fixes: #864