chore(nit): Fix overlap in state machine diagram

open-contracting · Dec 2, 2024 · de47d21 · de47d21
1 parent 41bff30
commit de47d21
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/app/models.py b/app/models.py
@@ -173,8 +173,9 @@ class ApplicationStatus(StrEnum):
     #:
     #: (``/applications/email-sme/{id}``)
     INFORMATION_REQUESTED = i("INFORMATION_REQUESTED")
-    #: Borrower doesn't accept or decline the invitation, doesn't submit the application or information requested, or
-    #: doesn't start external onboarding while the lender hasn't started application review.
+    #: Borrower doesn't accept or decline the invitation, doesn't submit the application or information requested,
+    #: doesn't start external onboarding while the lender hasn't started application review, or doesn't respond to
+    #: the lender externally.
     #:
     #: (:typer:`python-m-app-update-applications-to-lapsed`)
     LAPSED = i("LAPSED")

diff --git a/app/routers/applications.py b/app/routers/applications.py
@@ -543,8 +543,7 @@ async def lapse_application(
         models.Application,
         Depends(
             dependencies.get_scoped_application_as_user(
-                roles=(models.UserType.FI,),
-                statuses=(models.ApplicationStatus.STARTED,),
+                roles=(models.UserType.FI,), statuses=(models.ApplicationStatus.STARTED,)
             )
         ),
     ],

diff --git a/docs/_static/state-machine.png b/docs/_static/state-machine.png
diff --git a/docs/contributing/index.rst b/docs/contributing/index.rst
@@ -268,18 +268,18 @@ Application status transitions
    https://play.d2lang.com
    https://pincel.app/tools/svg-to-png
    α -> PENDING: Credere sends an invitation to the borrower
-   PENDING -> LAPSED: borrower doesn't accept or decline the invitation
+   PENDING -> LAPSED: borrower doesn't\naccept or decline the invitation
    PENDING -> DECLINED: borrower declines the invitation
    PENDING -> ACCEPTED: borrower accepts the invitation
-   ACCEPTED -> LAPSED: borrower doesn't submit the application
+   ACCEPTED -> LAPSED: borrower doesn't\nsubmit the application
    ACCEPTED -> SUBMITTED: borrower submits the application
-   SUBMITTED -> LAPSED: borrower doesn't start external onboarding {class: external}
+   SUBMITTED -> LAPSED: borrower doesn't\nstart external onboarding {class: external}
    SUBMITTED -> STARTED: lender starts application review
    STARTED -> INFORMATION_REQUESTED: lender requests\nthe borrower to update a document {class: native}
    STARTED -> REJECTED: lender rejects the application
    STARTED -> APPROVED: lender approves the application
-   STARTED -> LAPSED: lender lapses the application if the supplier is unresponsive during the review process
-   INFORMATION_REQUESTED -> LAPSED: borrower doesn't submit the information requested {class: native}
+   STARTED -> LAPSED: lender lapses the application if the borrower\nis unresponsive to external messages
+   INFORMATION_REQUESTED -> LAPSED: borrower doesn't\nsubmit the information requested {class: native}
    INFORMATION_REQUESTED -> STARTED: borrower updates the document {class: native}
    classes: {
      native.style.stroke: maroon