Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI logos: allow OCP admins to upload a FI logo, and show it in their credit products #175

Open
yolile opened this issue Sep 21, 2023 · 1 comment
Labels
chore topic: models Relating to the ORM or database integration

Comments

@yolile
Copy link
Member

yolile commented Sep 21, 2023

Right now the quick implementation was to add the logo in the front end as an asset and only store the file name in the FI form. The proper implementation would be to upload the image as part of the FI form.

@yolile yolile added the non-MVP label Sep 21, 2023
@jpmckinney jpmckinney added the enhancement New feature or request label Oct 23, 2023
@jpmckinney jpmckinney added this to the Post-MVP milestone Oct 23, 2023
@yolile yolile moved this to 📋 Backlog in Credere optimization backlog May 7, 2024
@sebasdocp sebasdocp moved this from 📋 Backlog to Priority in Credere optimization backlog May 8, 2024
@sebasdocp sebasdocp added status: idea Up for consideration from the team and removed status: idea Up for consideration from the team labels May 8, 2024
@jpmckinney jpmckinney removed this from the Post-MVP milestone Aug 9, 2024
@yolile yolile unassigned nahu Sep 6, 2024
@jpmckinney jpmckinney added chore topic: models Relating to the ORM or database integration and removed enhancement New feature or request labels Sep 6, 2024
@jpmckinney
Copy link
Member

In advance of the frontend changes, we can already make the db changes, and manually run a SQL query to add images. This would reduce coupling between logo_filename and files in git in the frontend.

@jpmckinney jpmckinney changed the title FI logos: allow OCP admins to upload a FI logo to be shown in their credit products FI logos: allow OCP admins to upload a FI logo, and show it in their credit products Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore topic: models Relating to the ORM or database integration
Projects
No open projects
Status: Planning / Design
Development

No branches or pull requests

4 participants